Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] account_analytic_document_date: New module account_analyt… #694

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][ADD] account_analytic_document_date: New module account_analyt… #694

wants to merge 1 commit into from

Conversation

BernatObrador
Copy link
Contributor

@BernatObrador BernatObrador commented Sep 30, 2024 •
edited
Loading

This module adds an other date to the account.move for analytics proposits

Usage:

  1. Set Document Date on Invoice:

    • Navigate to the invoice and set the document date.
    • If the document date is not set, it will automatically be assigned the invoice date upon confirmation.

  2. Analytic Line Generation:

    • If any line has analytic information, the generated analytic entry will inherit the document date.

  3. Setting Document Date in Reconcile View:

    • You can also set the document date from the reconciliation view, but this option is available only during manual reconciliation.

cc https://github.com/APSL 160768
@miquelalzanillas @lbarry-apsl @javierobcn @peluko00 @ppyczko please review

@BernatObrador BernatObrador force-pushed the 16.0-add-account_analytic_document_date branch 2 times, most recently from 2e75749 to 6066e28 Compare September 30, 2024 06:16
peluko00
peluko00 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review and tested in runboat

@BernatObrador BernatObrador force-pushed the 16.0-add-account_analytic_document_date branch from 6066e28 to a8f05bb Compare September 30, 2024 12:09
ppyczko
ppyczko approved these changes Oct 2, 2024
View reviewed changes
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@BernatObrador BernatObrador force-pushed the 16.0-add-account_analytic_document_date branch 5 times, most recently from 73bc5d2 to edd9720 Compare October 3, 2024 12:50
@BernatObrador
Copy link
Contributor Author

@pedrobaeza Could you review please?

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 6, 2024
pedrobaeza
pedrobaeza reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the goal of having another date. I would understand that you want a different date for the analytic line, but not having dual dates.

account_analytic_document_date/i18n/ca_ES.po Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be ca.po

@BernatObrador BernatObrador force-pushed the 16.0-add-account_analytic_document_date branch 2 times, most recently from e66c942 to d2bc8be Compare December 10, 2024 10:40
@BernatObrador BernatObrador force-pushed the 16.0-add-account_analytic_document_date branch from d2bc8be to f7a8703 Compare December 20, 2024 11:41
@BernatObrador
Copy link
Contributor Author

@pedrobaeza
The module introduces a new field in the accounting records to specify the "Accrual Date" for income and expenses. This field is crucial for accurately tracking when the revenue or expense is earned or incurred, regardless of the invoice creation date.

For instance, if an invoice is created in December but refers to sales made in November, the Accrual Date allows us to reflect this correctly in our accounting records. This ensures compliance with accrual-based accounting principles and provides better insights into the financial period to which transactions belong.

This feature is particularly valuable for businesses that need to differentiate between the accounting period of transaction occurrence and the timing of document issuance.

pedrobaeza
pedrobaeza requested changes Dec 20, 2024
View reviewed changes
account_analytic_document_date/__manifest__.py Outdated Show resolved Hide resolved
account_analytic_document_date/__manifest__.py Outdated Show resolved Hide resolved
account_analytic_document_date/static/description/icon.svg Outdated Show resolved Hide resolved
account_analytic_document_date/models/account_move.py Outdated Show resolved Hide resolved
@BernatObrador BernatObrador force-pushed the 16.0-add-account_analytic_document_date branch from f7a8703 to d16a0c3 Compare December 23, 2024 11:50
@BernatObrador BernatObrador force-pushed the 16.0-add-account_analytic_document_date branch from d16a0c3 to f509eb3 Compare December 27, 2024 09:17
@BernatObrador
Copy link
Contributor Author

@pedrobaeza Could you please review again?

pedrobaeza
pedrobaeza reviewed Dec 27, 2024
View reviewed changes
account_analytic_document_date/__manifest__.py
"summary": "Account Analytic Document Date",
"version": "16.0.1.0.0",
"website": "https://github.com/OCA/account-analytic",
"author": ("(Nagarro - APSL), Odoo Community Association (OCA)"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the usual form (between parenthesis) of you company name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza requested changes

@ppyczko ppyczko ppyczko approved these changes

@peluko00 peluko00 peluko00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@BernatObrador @pedrobaeza @peluko00 @ppyczko @OCA-git-bot